From f527eace6728e075f43d2f2e3d2474a855ae06b6 Mon Sep 17 00:00:00 2001 From: bwarsaw <> Date: Fri, 10 Oct 2003 04:11:12 +0000 Subject: MarshalSwitchboard._ext_write(), ASCIISwitchboard._ext_write(): Promote SYNC_AFTER_WRITE to a Defaults.py/mm_cfg.py variable after all. --- Mailman/Queue/Switchboard.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Mailman/Queue/Switchboard.py b/Mailman/Queue/Switchboard.py index 4a56223d..6093623e 100644 --- a/Mailman/Queue/Switchboard.py +++ b/Mailman/Queue/Switchboard.py @@ -56,10 +56,6 @@ except NameError: True = 1 False = 0 -# This flag causes Mailman to fsync() the file after writing and flushing its -# contents. While this ensures the data is written to disk, avoiding data -# loss, it is a huge performance killer. -SYNC_AFTER_WRITE = False # This flag causes messages to be written as pickles (when True) or text files # (when False). Pickles are more efficient because the message doesn't need # to be re-parsed every time it's unqueued, but pickles are not human readable. @@ -255,7 +251,7 @@ class MarshalSwitchboard(_Switchboard): marshal.dump(dict, fp) # Make damn sure that the data we just wrote gets flushed to disk fp.flush() - if SYNC_AFTER_WRITE: + if mm_cfg.SYNC_AFTER_WRITE: os.fsync(fp.fileno()) fp.close() @@ -327,7 +323,7 @@ class ASCIISwitchboard(_Switchboard): print >> fp, '%s = %s' % (k, repr(v)) # Make damn sure that the data we just wrote gets flushed to disk fp.flush() - if SYNC_AFTER_WRITE: + if mm_cfg.SYNC_AFTER_WRITE: os.fsync(fp.fileno()) fp.close() -- cgit v1.2.3