From e9311545f5e101289a6d1f1b54eface70cf83717 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Wed, 14 Jan 2009 11:41:22 +0100 Subject: playlist: safely search the playlist for deleted song When a song file is deleted during database update, all pointers to it must be removed from the playlist. The "for" loop in deleteASongFromPlaylist() did not deal with multiple copies of the deleted song properly, and left instances of the (to-be-invalidated) pointer in. Fix this by reversing the loop. --- NEWS | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'NEWS') diff --git a/NEWS b/NEWS index 1326154fe..ba0574a8b 100644 --- a/NEWS +++ b/NEWS @@ -15,8 +15,10 @@ MPD 0.14.1 - not yet released * configure.ac: check for pkg-config before using it * fix minor memory leak in decoder_tag() * fix cross-fading bug: it used to play some chunks of the new song twice -* playlist: fix assertion failure during playlist load -* playlist: implement Fisher-Yates shuffle properly +* playlist + - fix assertion failure during playlist load + - implement Fisher-Yates shuffle properly + - safely search the playlist for deleted song * use custom PRNG for volume dithering (speedup) * detect libid3tag without pkg-config -- cgit v1.2.3