From b97139a13b5b55da1858428c6dc802b5b50ffc9f Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 27 Jan 2008 23:12:35 +0000 Subject: Redirect stdin *before* we establish a listen socket This way we'll avoid listening on fd=0 and have a better chance of having fd=0 as /dev/null git-svn-id: https://svn.musicpd.org/mpd/branches/branch-0.13.0-fixes@7174 09075e82-0dd4-0310-85a5-a0d7c8717e4f --- src/log.c | 15 --------------- 1 file changed, 15 deletions(-) (limited to 'src/log.c') diff --git a/src/log.c b/src/log.c index 974c07146..a14b653b8 100644 --- a/src/log.c +++ b/src/log.c @@ -37,20 +37,6 @@ static int err_fd = -1; static const char *out_filename; static const char *err_filename; -/* redirect stdin to /dev/null to work around a libao bug */ -static void redirect_stdin(void) -{ - int fd, st; - struct stat ss; - - if ((st = fstat(STDIN_FILENO, &ss)) < 0 || ! isatty(STDIN_FILENO)) - return; - if ((fd = open("/dev/null", O_RDONLY)) < 0) - FATAL("failed to open /dev/null %s\n", strerror(errno)); - if (dup2(fd, STDIN_FILENO) < 0) - FATAL("dup2 stdin: %s\n", strerror(errno)); -} - static void redirect_logs(void) { assert(out_fd > 0); @@ -180,7 +166,6 @@ void setup_log_output(const int use_stdout) redirect_logs(); stdout_mode = 0; } - redirect_stdin(); } #define log_func(func,level,fp) \ -- cgit v1.2.3